Fix case when cancellation token was requested but query was not canceled #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run a command using TrinoCommand with StatementClientV1 internally, there is an issue if you want to cancel the query from execution on server side. The cancelation token is processed in HttpClient at GetResourceAsync, but since the code around the call area is not covered with any try / catch, the flow of termination of command is dropped and the command continues to run on server side. And all this going on while the code requested this command execution is no longer awaiting for result of it. Thus, it is necessary to catch the exception and call cancelation of server execution of specified command.
The code was unreachable here.
With the proposed code change we will cancel the run of command whenever the cancellation requested.