Skip to content

test: prefill profile data for Alice and Bob #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

shuuji3
Copy link
Collaborator

@shuuji3 shuuji3 commented Feb 19, 2025

resolve #59

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for tsky canceled.

Name Link
🔨 Latest commit 7836b14
🔍 Latest deploy log https://app.netlify.com/sites/tsky/deploys/67bb5936a1229800090cd3b3

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Coverage Report for ./packages/client/

Status Category Percentage Covered / Total
🔵 Lines 20.61% 40 / 194
🔵 Statements 20.51% 40 / 195
🔵 Functions 19.23% 20 / 104
🔵 Branches 27.65% 13 / 47
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/client/globalSetup.ts 0% 100% 0% 0% 18-92
Generated in workflow #205 for commit 7836b14 by the Vitest Coverage Report Action

@shuuji3 shuuji3 force-pushed the shuuji3/test/prefill-alice-and-bob-profile branch from bb068e7 to c82429b Compare February 19, 2025 16:15
@shuuji3 shuuji3 changed the title Prefill profile data for Alice and Bob for testing test: prefill profile data for Alice and Bob for testing Feb 19, 2025
@shuuji3 shuuji3 changed the title test: prefill profile data for Alice and Bob for testing test: prefill profile data for Alice and Bob Feb 19, 2025
@shuuji3 shuuji3 force-pushed the shuuji3/test/prefill-alice-and-bob-profile branch from 12ef6f7 to fdea50f Compare February 19, 2025 16:21
@shuuji3
Copy link
Collaborator Author

shuuji3 commented Feb 23, 2025

CI Error questions:

  • who created this directory
  • who is trying to delete this, thinking this is a file 🤔
...
packages/client test:coverage: ⎯⎯⎯⎯⎯⎯⎯ Startup Error ⎯⎯⎯⎯⎯⎯⎯⎯
packages/client test:coverage: [SystemError [ERR_FS_EISDIR]: Path is a directory: rm returned EISDIR (is a directory) /tmp/22vdcijixvmru] {
packages/client test:coverage:   code: 'ERR_FS_EISDIR',
packages/client test:coverage:   info: {
packages/client test:coverage:     code: 'EISDIR',
packages/client test:coverage:     message: 'is a directory',
packages/client test:coverage:     path: '/tmp/22vdcijixvmru',
packages/client test:coverage:     syscall: 'rm',
packages/client test:coverage:     errno: 21
packages/client test:coverage:   },
packages/client test:coverage:   errno: [Getter/Setter: 21],
packages/client test:coverage:   syscall: [Getter/Setter: 'rm'],
packages/client test:coverage:   path: [Getter/Setter: '/tmp/22vdcijixvmru']
packages/client test:coverage: }
packages/client test:coverage: Failed

This can be reproduced by CI=1 pnpm -r test:coverage on local.

I suspected vitest coverage code but it was actually PDS's temp directory:

> tree /tmp/74wztj2b3hjzk
/tmp/74wztj2b3hjzk
├── did:plc:4datq2ql2tvfwlmenljndyl6
│   └── bafkreifl3xu4hsmmlov54dcblrswri3xrjm6aivrj5zvrqdmgkuyuontpm
├── did:plc:vsxioche6bsk4myywdbaqi45
│   └── bafkreifl3xu4hsmmlov54dcblrswri3xrjm6aivrj5zvrqdmgkuyuontpm
└── tempt
    ├── did:plc:4datq2ql2tvfwlmenljndyl6
    └── did:plc:vsxioche6bsk4myywdbaqi45

5 directories, 2 files

where bafkreifl3xu4hsmmlov54dcblrswri3xrjm6aivrj5zvrqdmgkuyuontpm is a blob file of Alice's profile avatar image (normal jpeg binary file).

@shuuji3 shuuji3 marked this pull request as ready for review February 23, 2025 17:23
@shuuji3
Copy link
Collaborator Author

shuuji3 commented Feb 23, 2025

Errors in testing were fixed by correcting the issue in internal-dev-env package. Also, I solved other issues.

@shuuji3
Copy link
Collaborator Author

shuuji3 commented Feb 25, 2025

Merging this PR to test additional records with #74.

@shuuji3 shuuji3 merged commit 3e63566 into main Feb 25, 2025
7 checks passed
@shuuji3 shuuji3 deleted the shuuji3/test/prefill-alice-and-bob-profile branch February 25, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefill profile data for Alice and Bob for testing
1 participant