Skip to content

Alpha Release Notes: bug fix and code change to match change in website. #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

SixParQuatre
Copy link

all in the title!

@unitycoder
Copy link
Owner

thanks i'll have a look.

@unitycoder
Copy link
Owner

still thinking about the comment and that while loop..

it would be confusing if "wrong version" notes open,
but also annoying if there would be error messagebox..
196595e#diff-b045d7dc0df9dfd6e7d9ecbe44bc4e5d312e040a5c2264dc22d154bf08978548R610

maybe it should just fallback to old release notes (even though alpha notes is enabled),
could display statusbar message about it.. or append something in the url #no_alpha_release_notes_for_this_version something

@SixParQuatre
Copy link
Author

SixParQuatre commented Jun 4, 2024

I don't love it either. I think the better UX would be to have 2 buttons: "Release Notes" and "Cumulated Release Notes".
Releases Notes just shows the individual release notes; and default to the non-alpha version when a non-final version is picked.
Cumulated Release Notes is then disabled if a non-final version is selected; with the tooltip mentioning that it only works for final versions.
image

@unitycoder
Copy link
Owner

sorry haven't had time to look into this more yet..

still wondering what is the best way to handle it..

one other option:
could disable "release notes" button, if its not available for selected version,
and then enable cumulative button..

@SixParQuatre
Copy link
Author

No worries! I've actually made the change to have 2 button; I wanted to test it locally for a few day and clean the code up before I submitted a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants