-
Notifications
You must be signed in to change notification settings - Fork 407
T7384: Radius patch for Dns-Server-IPv6-Address attribute - accel-ppp #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
❌ |
It is a nice practice to create a feature request from https://vyos.dev/ |
@sever-sever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as it was tested by users, ref accel-ppp/accel-ppp#69
@AlexIT-FT Your vyos.dev account is active. Could you please create a task and include its number in the commit message and the PR title? Then we can merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task T7384 created at vyos.dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is good now. The commit message also needs to include the task number, and it's better to make it descriptive, like T7384: add a patch to support the DNS-Server-IPv6-Address attribute
I'm sorry for my ineptitude, but it's my first time. |
In the git tool (console/terminal)
|
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
I tried many times in several ways (cli, web, ...) but the result is always the same. The error is always relate to the very first commit message.
What am I messing up ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch is already tested in rolling. The PR is now compliant with contributing guidelines so I see no reasons not to merge it.
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file
Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
All credits to Ben Hardill
Change summary
Just to manage the attribute Dns-Server-IPv6-Address from Radius
Types of changes
Related Task(s)
T7384 accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute
Related PR(s)
Checklist: