Skip to content

T7384: Radius patch for Dns-Server-IPv6-Address attribute - accel-ppp #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 24, 2025

Conversation

AlexIT-FT
Copy link
Contributor

@AlexIT-FT AlexIT-FT commented Mar 13, 2025

This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/

All credits to Ben Hardill

Change summary

Just to manage the attribute Dns-Server-IPv6-Address from Radius

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

T7384 accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
@AlexIT-FT AlexIT-FT requested a review from a team as a code owner March 13, 2025 04:27
Copy link

github-actions bot commented Mar 13, 2025


PR title does not match the required format

@github-actions github-actions bot added the current VyOS rolling release label Mar 13, 2025
@AlexIT-FT AlexIT-FT changed the title Create 0002-Radius-Dns-Server-IPv6-Address.patch accel-ppp: patch : 0002-Radius-Dns-Server-IPv6-Address.patch Mar 13, 2025
@AlexIT-FT AlexIT-FT changed the title accel-ppp: patch : 0002-Radius-Dns-Server-IPv6-Address.patch accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute Mar 13, 2025
@sever-sever
Copy link
Member

It is a nice practice to create a feature request from https://vyos.dev/
And refer to this task in the commit message and PR title.

@AlexIT-FT
Copy link
Contributor Author

@sever-sever
sorry, I'm new to this kind of things, next time for sure
now, just waiting for acount approval in vyod.dev

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as it was tested by users, ref accel-ppp/accel-ppp#69

@dmbaturin
Copy link
Member

@AlexIT-FT Your vyos.dev account is active. Could you please create a task and include its number in the commit message and the PR title? Then we can merge the PR.

Copy link
Contributor Author

@AlexIT-FT AlexIT-FT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task T7384 created at vyos.dev

@AlexIT-FT AlexIT-FT changed the title accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute T7384 accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute Apr 22, 2025
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is good now. The commit message also needs to include the task number, and it's better to make it descriptive, like T7384: add a patch to support the DNS-Server-IPv6-Address attribute

@AlexIT-FT
Copy link
Contributor Author

The title is good now. The commit message also needs to include the task number, and it's better to make it descriptive, like T7384: add a patch to support the DNS-Server-IPv6-Address attribute

I'm sorry for my ineptitude, but it's my first time.
If I click on the "commit" label (on top of this page), I read my commit message (dated Mar 13, 2025) but it seems to be readonly, I can't edit it.
What should I do to modify the commit message.

@sever-sever
Copy link
Member

What should I do to modify the commit message.

In the git tool (console/terminal)

git commit --amend
git push --force

This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
@AlexIT-FT AlexIT-FT changed the title T7384 accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute T7384: Radius patch for Dns-Server-IPv6-Address attribute - accel-ppp Apr 22, 2025
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
@AlexIT-FT
Copy link
Contributor Author

The title is good now. The commit message also needs to include the task number, and it's better to make it descriptive, like T7384: add a patch to support the DNS-Server-IPv6-Address attribute

I tried many times in several ways (cli, web, ...) but the result is always the same.

image

The error is always relate to the very first commit message.

Commit message 'Create 0002-Radius-Dns-Server-IPv6-Address.patch' does not match the required format!

What am I messing up ?

@dmbaturin dmbaturin dismissed their stale review April 24, 2025 14:43

Changes are already addressed.

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is already tested in rolling. The PR is now compliant with contributing guidelines so I see no reasons not to merge it.

@dmbaturin dmbaturin merged commit 5107733 into vyos:current Apr 24, 2025
2 of 3 checks passed
@github-actions github-actions bot added the mirror-initiated This PR initiated for mirror sync workflow label Apr 24, 2025
@vyosbot vyosbot added mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants