Skip to content

Adds non-interactive shell as execution env #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adds non-interactive shell as execution env #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/analytics/executionEnvs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ export const executionEnvs = {
name: "GH Codespaces",
},
ci: { contextKey: "ci", name: "CI" },
nonInteractiveShell: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all it takes for our code to extract the non_interactive_shell events as a separate group that's not counted towards our regular usage.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll believe you 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I remember when we were refactoring this, it paid off now :)!

contextKey: "non_interactive_shell",
name: "Non-interactive shell",
},
};

// Organize events by the execution env:
Expand Down
2 changes: 1 addition & 1 deletion src/analytics/reports/periodReport/userActivityReport.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export async function generateUserActivityReport(
"==== Unique Active Users ====",
`During last ${periodName}:`,
`- Local: ${totalNumOfLocalUsersInLastPeriod}`,
`- Cloud: ${prettyNonLocalMetrics}`,
`- Other: ${prettyNonLocalMetrics}`,
`Table "Num unique active users per ${periodName} by age":`,
"```",
tableOfActiveUsersPerPeriodByAge.toString(),
Expand Down