-
Notifications
You must be signed in to change notification settings - Fork 3
collect action numbers metrics #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
currently Laravel is not happy with the prepared statement:
|
@@ -39,12 +39,20 @@ public function testRunJobForAllWikisIncludingDeletedWikis() | |||
|
|||
$this->assertDatabaseHas('wiki_daily_metrics', [ | |||
'wiki_id' => $activeWiki->id, | |||
'date' => Carbon::today()->toDateString() | |||
'date' => Carbon::today()->toDateString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about how we could "properly" test this and concluded that this is one of the main weaknesses of this approach. We're so tightly bound to the implementation / layout of mediawiki's private dbs that this isn't really possible to seed with good test data. Hence why this just lives as a null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests fixed!
https://phabricator.wikimedia.org/T383427
based on #912
Adds data points to WikiMetrics model: