Skip to content

Allow overlapping BCD keys #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions features/text-wrap-pretty.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ name: "text-wrap: pretty"
description: "The `text-wrap: pretty` CSS declaration prioritizes better layout over speed when text is broken into multiple lines."
spec: https://drafts.csswg.org/css-text-4/#valdef-text-wrap-style-pretty
group: text-wrap
compat_features:
- css.properties.text-wrap.pretty
- css.properties.text-wrap-style.pretty
19 changes: 16 additions & 3 deletions features/text-wrap-pretty.yml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,21 @@
status:
baseline: false
support:
chrome: "117"
chrome_android: "117"
edge: "117"
chrome: "130"
chrome_android: "130"
edge: "130"
compat_features:
# baseline: false
# support:
# chrome: "117"
# chrome_android: "117"
# edge: "117"
- css.properties.text-wrap.pretty

# ⬇️ Same status as overall feature ⬇️
# baseline: false
# support:
# chrome: "130"
# chrome_android: "130"
# edge: "130"
- css.properties.text-wrap-style.pretty
9 changes: 1 addition & 8 deletions index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,15 +167,8 @@ for (const [key, data] of yamlEntries('features')) {
// no effect on what web-features users see.
data.compat_features.sort();

// Check that no BCD key is used twice until the meaning is made clear in
// https://github.com/web-platform-dx/web-features/issues/1173.
for (const bcdKey of data.compat_features) {
const otherKey = bcdToFeatureId.get(bcdKey);
if (otherKey) {
throw new Error(`BCD key ${bcdKey} is used in both ${otherKey} and ${key}, which creates ambiguity for some consumers. Please see https://github.com/web-platform-dx/web-features/issues/1173 and help us find a good solution to allow this.`);
} else {
bcdToFeatureId.set(bcdKey, key);
}
bcdToFeatureId.set(bcdKey, key);
}
}

Expand Down