Fixed bug - Support multiselect with integers #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return options; | ||
| } | ||
|
|
||
| public void setOptions(Map<String, V> options) { | ||
| public void setOptions(Map<Object, V> options) { | ||
| boolean match = options.keySet().stream().allMatch(key -> key instanceof String || key instanceof Integer); |
There was a problem hiding this comment.
I assume only Strings and Integers are allowed here, unfortunately I had to change String here to Object, hope this validation is enough
| @@ -114,7 +114,7 @@ const CodeArgumentInput: React.FC<CodeArgumentInputProps> = ({ arg }) => { | |||
| orientation="horizontal" | |||
| label={argLabel(arg)} | |||
| errorMessage={fieldState.error ? fieldState.error.message : undefined} | |||
| validationState={fieldState.error ? 'invalid' : 'valid'} | |||
There was a problem hiding this comment.
validationState is deprecated
| @@ -171,9 +172,9 @@ const CodeArgumentInput: React.FC<CodeArgumentInputProps> = ({ arg }) => { | |||
| <div> | |||
| <ListView | |||
| {...field} | |||
| maxHeight="size-1600" | |||
| maxHeight="size-2000" | |||
There was a problem hiding this comment.
This way always exactly 4 items display
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug by extending support for multiselect with integer keys in both the frontend and backend, while also refining validation handling in the CodeArgumentInput component.
- Updated TypeScript types to allow integer keys for multiselect options.
- Modified CodeArgumentInput to adjust validation and error handling.
- Adjusted Java code to accept integer keys and added a runtime type check in setOptions.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui.frontend/src/utils/api.types.ts | Updated MultiSelectArgument options type to support both string and number keys. |
| ui.frontend/src/components/CodeArgumentInput.tsx | Revised validation logic and UI props to better handle multiselect inputs. |
| core/src/main/java/com/vml/es/aem/acm/core/code/arg/MultiSelectArgument.java | Changed options type and added a key type check to restrict keys to string or integer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.