Handwritten asm build prep, add handwritten asm for the code segment #1807
+612
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tack.s, add handwritten asm for the code segment
hensldm
added
code
Needs-second-approval
hensldm
reviewed
Apr 19, 2025
|
|
||
| .text | ||
|
|
||
| /** |
There was a problem hiding this comment.
We can probably delete the duplicate comment in kanread.h now.
| .text | ||
| .align 5 | ||
|
|
||
| /* Copy 0x20 bytes at a1 to a0, with word alignment */ |
There was a problem hiding this comment.
Can you add a function declaration comment as well (like you did for the other 2), even if it is rather simple?
AngheloAlf
reviewed
Apr 21, 2025
Comment on lines
+648
to
+649
| $(BUILD_DIR)/src/makerom/ipl3.o: $(EXTRACTED_DIR)/incbin/ipl3 | ||
| $(OBJCOPY) -I binary -O elf32-big --rename-section .data=.text $< $@ |
There was a problem hiding this comment.
What's the advantage of using objcopy over incbin assembly files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.