std.crypto.codecs: fixed Base64 and Hex const name #23566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imo codecs.zig is what's wrong because the structs dont have any fields so theyre namespaces according to the style guide |
|
LGTM! |
|
Meghan is right though. Since these are namespaces, not types, they should be lower case. |
jedisct1
approved these changes
Apr 27, 2025
the is right.so need change https://github.com/ziglang/zig/blob/master/lib/std/crypto/codecs.zig#L2 const name. |
|
-> #23706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is used at https://github.com/ziglang/zig/blob/master/lib/std/crypto/codecs.zig#L2