-
Notifications
You must be signed in to change notification settings - Fork 306
Upgrade Flutter, packages and Android build dependencies #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8c1946a
ios deps: Take auto updates to Podfile.lock
rajveermalviya 24c3807
deps: Upgrade Flutter to 3.32.0-1.0.pre.87
rajveermalviya 6d2a102
deps: Update app_settings to 6.1.1, from 5.2.0
rajveermalviya 3013e07
deps: Update file_picker to 10.1.2, from 9.2.1
rajveermalviya e7a9f66
deps: Upgrade firebase_core, firebase_messaging to latest
rajveermalviya 830b94d
deps: Update flutter_checks to 0.1.2, from 0.1.1
rajveermalviya feedc06
deps: Update pigeon to 25.3.1, from 25.0.0
rajveermalviya 9d92cca
deps: Upgrade packages within constraints (tools/upgrade pub)
rajveermalviya 553586d
deps android: Upgrade Gradle to 8.13, from 8.9
rajveermalviya 522c026
deps android: Upgrade Kotlin to 2.1.20, from 2.0.10
rajveermalviya b431d8d
deps android: Upgrade Android Gradle Plugin to 8.9.1, from 8.5.2
rajveermalviya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<issues format="6" by="lint 8.5.2" type="baseline" client="gradle" dependencies="false" name="AGP (8.5.2)" variant="all" version="8.5.2"> | ||
|
||
<issue | ||
id="InvalidPackage" | ||
message="Invalid package reference in library; not included in Android: `javax.xml.stream`. Referenced from `org.apache.tika.utils.XMLReaderUtils`."> | ||
<location | ||
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.apache.tika/tika-core/3.1.0/6ba44a9ddf8f6f2b4bc88e8bc64269aea0424607/tika-core-3.1.0.jar"/> | ||
</issue> | ||
|
||
</issues> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, annoying.
Seems like the impact of this, if there is one, would be that it crashes when trying to read some XML file. Is there a file_picker upstream issue for this? If we're lucky, someone has already investigated and has a convincing reason it won't matter for our use (or perhaps even for file_picker's use in general).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you said in today's call that you looked in the package's tracker and didn't find an issue for this.
That's fine and we can leave it there — this probably doesn't affect our app's behavior, and we're planning to switch off this library in the future anyway. The commit message should just mention that, though: the fact that you looked and didn't find an upstream issue.