Skip to content

Skip imports of mbed-os in libraries imported by apps #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Skip imports of mbed-os in libraries imported by apps #473

wants to merge 1 commit into from

Conversation

wdwalker
Copy link

The change is rather straightforward - if we come across an mbed-os.lib file in a library imported by an app, skip it. My test set up is as follows:

  • A library that has an mbed-os.lib in it.
  • An app that imports that library as well as mbed-os (e.g., has two *.lib files).

mbed import of both yields the desired results:

  • Importing the library alone gets me an mbed-os to work with
  • Importing the app gets me the library and mbed-os in the top level directory with no redundant mbed-os import

My knowledge of mbed-cli.py is limited, however, so the above may not be sufficient. Please review - I will not be at all offended by rejection.

Fixes #472 - mbed-cli can clone mbed-os.lib more than once.

@wdwalker
Copy link
Author

OK - looks like the automated tests show my check has a false positive. I'll dig into it.

@wdwalker
Copy link
Author

Withdrawing this until I can get a better fix.

@wdwalker wdwalker closed this Apr 12, 2017
@wdwalker wdwalker deleted the skip-mbed-os-in-lib-dirs branch April 12, 2017 22:21
@wdwalker wdwalker restored the skip-mbed-os-in-lib-dirs branch April 12, 2017 22:22
@wdwalker wdwalker deleted the skip-mbed-os-in-lib-dirs branch April 12, 2017 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant