[UR][Graph] command-buffer unsupported OpenCL CTS tests #18183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently limitations on what commands can be added to a SYCL-Graph that we document in the [design doc](https://github.com/intel/llvm/blob/sycl/sycl/doc/design/CommandGraph.md#opencl) and mark as unsupported in Graph E2E tests. However, we never marked the equivalent UR command-buffer commands as unsupported in the CTS, so they will currently fail when testing against an OpenCL backend with support for the extension. Address this by marking CTS tests which use these commands as unsupported.
Bensuo
approved these changes
Apr 25, 2025
|
@intel/llvm-gatekeepers This is good to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently limitations on what commands can be added to a SYCL-Graph that we document in the design doc and mark as unsupported in Graph E2E tests.
However, we never marked the equivalent UR command-buffer commands as unsupported in the CTS, so they will currently fail when testing against an OpenCL backend with support for the extension. Address this by marking CTS tests which use these commands as unsupported.
Note that this will conflict with #18177 in that some CTS tests can be re-enabled, but I can resolve that based on whatever merges first.