Skip to content

[UR][Graph] command-buffer unsupported OpenCL CTS tests #18183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,18 @@ struct urCommandBufferCommandsTest
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urCommandBufferCommandsTest);

TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendUSMMemcpyExp) {
// No USM memcpy command in cl_khr_command_buffer
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

ASSERT_SUCCESS(urCommandBufferAppendUSMMemcpyExp(
cmd_buf_handle, device_ptrs[0], device_ptrs[1], allocation_size, 0,
nullptr, 0, nullptr, nullptr, nullptr, nullptr));
}

TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendUSMFillExp) {
// No USM fill command in cl_khr_command_buffer
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

uint32_t pattern = 42;
ASSERT_SUCCESS(urCommandBufferAppendUSMFillExp(
cmd_buf_handle, device_ptrs[0], &pattern, sizeof(pattern),
Expand All @@ -83,13 +89,21 @@ TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendMemBufferCopyRectExp) {
}

TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendMemBufferReadExp) {
// No buffer read command in cl_khr_command_buffer
// See https://github.com/KhronosGroup/OpenCL-Docs/issues/1281
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

std::array<uint32_t, elements> host_data{};
ASSERT_SUCCESS(urCommandBufferAppendMemBufferReadExp(
cmd_buf_handle, buffers[0], 0, allocation_size, host_data.data(), 0,
nullptr, 0, nullptr, nullptr, nullptr, nullptr));
}

TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendMemBufferReadRectExp) {
// No buffer read command in cl_khr_command_buffer
// See https://github.com/KhronosGroup/OpenCL-Docs/issues/1281
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

std::array<uint32_t, elements> host_data{};
ur_rect_offset_t origin{0, 0, 0};
ur_rect_region_t region{4, 4, 1};
Expand All @@ -99,6 +113,10 @@ TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendMemBufferReadRectExp) {
}

TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendMemBufferWriteExp) {
// No buffer write command in cl_khr_command_buffer
// See https://github.com/KhronosGroup/OpenCL-Docs/issues/1281
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

std::array<uint32_t, elements> host_data{};
ASSERT_SUCCESS(urCommandBufferAppendMemBufferWriteExp(
cmd_buf_handle, buffers[0], 0, allocation_size, host_data.data(), 0,
Expand All @@ -107,6 +125,10 @@ TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendMemBufferWriteExp) {

TEST_P(urCommandBufferCommandsTest,
urCommandBufferAppendMemBufferWriteRectExp) {
// No buffer write command in cl_khr_command_buffer
// See https://github.com/KhronosGroup/OpenCL-Docs/issues/1281
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

std::array<uint32_t, elements> host_data{};
ur_rect_offset_t origin{0, 0, 0};
ur_rect_region_t region{4, 4, 1};
Expand All @@ -123,12 +145,18 @@ TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendMemBufferFillExp) {
}

TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendUSMPrefetchExp) {
// No Prefetch command in cl_khr_command_buffer
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

ASSERT_SUCCESS(urCommandBufferAppendUSMPrefetchExp(
cmd_buf_handle, device_ptrs[0], allocation_size, 0, 0, nullptr, 0,
nullptr, nullptr, nullptr, nullptr));
}

TEST_P(urCommandBufferCommandsTest, urCommandBufferAppendUSMAdviseExp) {
// No advise command in cl_khr_command_buffer
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

ASSERT_SUCCESS(urCommandBufferAppendUSMAdviseExp(
cmd_buf_handle, device_ptrs[0], allocation_size, 0, 0, nullptr, 0,
nullptr, nullptr, nullptr, nullptr));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
printFillTestString<urCommandBufferFillCommandsTest>);

TEST_P(urCommandBufferFillCommandsTest, Buffer) {
// No buffer read command in cl_khr_command_buffer
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

ASSERT_SUCCESS(urCommandBufferAppendMemBufferFillExp(
cmd_buf_handle, buffer, pattern.data(), pattern_size, 0, size, 0, nullptr,
0, nullptr, &sync_point, nullptr, nullptr));
Expand All @@ -128,6 +131,9 @@ TEST_P(urCommandBufferFillCommandsTest, Buffer) {
}

TEST_P(urCommandBufferFillCommandsTest, ExecuteTwice) {
// No buffer read command in cl_khr_command_buffer
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

ASSERT_SUCCESS(urCommandBufferAppendMemBufferFillExp(
cmd_buf_handle, buffer, pattern.data(), pattern_size, 0, size, 0, nullptr,
0, nullptr, &sync_point, nullptr, nullptr));
Expand All @@ -149,6 +155,9 @@ TEST_P(urCommandBufferFillCommandsTest, ExecuteTwice) {
}

TEST_P(urCommandBufferFillCommandsTest, USM) {
// No USM fill command in cl_khr_command_buffer
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

ASSERT_SUCCESS(urCommandBufferAppendUSMFillExp(
cmd_buf_handle, device_ptr, pattern.data(), pattern_size, size, 0,
nullptr, 0, nullptr, &sync_point, nullptr, nullptr));
Expand Down